Fix preconditioner when using EquationBC #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pbrubeck
reviewed
Oct 25, 2024
| @@ -44,7 +44,8 @@ def initialize(self, pc): | |||
|
|
|||
| (a, bcs) = self.form(pc, test, trial) | |||
|
|
|||
| form_assembler = get_assembler(a, bcs=bcs, form_compiler_parameters=fcp, mat_type=mat_type, options_prefix=options_prefix) | |||
| bcs_Jp = tuple(bc.extract_form('Jp') for bc in bcs) | |||
There was a problem hiding this comment.
This should go in self.form so every preconditioner gets the correct bcs
ksagiyam
force-pushed
the
ksagiyam/fix_pc_preconditioner
branch
from
e58987f to
f466ecd
Compare
ksagiyam
force-pushed
the
ksagiyam/fix_pc_preconditioner
branch
2 times, most recently
from
1a5ff73 to
72e9fdf
Compare
dham
approved these changes
Nov 6, 2024
connorjward
pushed a commit
that referenced
this pull request
Nov 25, 2024
--------- Co-authored-by: Aaron Baier-Reinio <baierreinio@maths.ox.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
EquationBCin PCs.