Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PetscCall() instead of CHKERRQ() in tinyasm #3959

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Use PetscCall() instead of CHKERRQ() in tinyasm #3959

merged 1 commit into from
Jan 9, 2025

Conversation

connorjward
Copy link
Contributor

Description

Also removes unused variables.

JHopeCollins
JHopeCollins approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@JHopeCollins JHopeCollins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI passing. Thanks Connor!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8156 ran6682 passed1474 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8162 ran7487 passed675 skipped0 failed

@connorjward connorjward enabled auto-merge (squash) January 9, 2025 12:00
@connorjward connorjward merged commit 39742a6 into master Jan 9, 2025
22 checks passed
@connorjward connorjward deleted the connorjward/fixup-tinyasm branch January 9, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JHopeCollins JHopeCollins JHopeCollins approved these changes

Assignees
No one assigned
Labels
macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjward @JHopeCollins