fem: Really fix CoordinateMapping changes for interpolation

Provide a cell integral_type for interpolation. This part needs bigger refactoring if we want interpolation onto faces (say).
firedrakeproject · May 4, 2021 · 49bbcff · 49bbcff
1 parent f6bdf1e
commit 49bbcff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/tsfc/driver.py b/tsfc/driver.py
@@ -350,6 +350,9 @@ def compile_expression_dual_evaluation(expression, to_element, *,
     # Translate to GEM
     kernel_cfg = dict(interface=builder,
                       ufl_cell=domain.ufl_cell(),
+                      # FIXME: change if we ever implement
+                      # interpolation on facets.
+                      integral_type="cell",
                       argument_multiindices=argument_multiindices,
                       index_cache={},
                       scalar_type=parameters["scalar_type"])

diff --git a/tsfc/fem.py b/tsfc/fem.py
@@ -136,10 +136,9 @@ def preprocess(self, expr, context):
         :arg context: The translation context.
         :returns: A new UFL expression
         """
-        is_facet = (self.interface.integration_dim !=
-                    self.interface.fiat_cell.get_dimension())
+        ifacet = self.interface.integral_type.startswith("interior_facet")
         return preprocess_expression(expr, complex_mode=context.complex_mode,
-                                     do_apply_restrictions=is_facet)
+                                     do_apply_restrictions=ifacet)
 
     @property
     def config(self):