Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include #127

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add missing include #127

merged 1 commit into from
Oct 4, 2023

Conversation

VladislavGrudinin
Copy link
Contributor

Got following error when compiling with clang:

/var/tmp/portage/dev-python/pywlroots-0.16.5/work/pywlroots-0.16.5-python3_11/build/temp.linux-x86_64-cpython-311/wlroots._ffi.c:6368:3: error: call to undeclared function 'wlr_keyboard_notify_modifiers'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
6368 | wlr_keyboard_notify_modifiers(x0, x1, x2, x3, x4);

This function was added in #123, but include was forgotten.

Copy link
Collaborator

@m-col m-col left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m-col m-col merged commit fb7e7d0 into flacjacket:main Oct 4, 2023
30 checks passed
@flacjacket
Copy link
Owner

Thanks for catching this! How did you setup to use clang to build the cffi module? I'm curious if we could do something similar in the CI so this could be caught automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants