Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(treewide): use mariadb commands and service instead of mysql #1489

Merged
merged 1 commit into from
Oct 10, 2023
Merged

refactor(treewide): use mariadb commands and service instead of mysql #1489

merged 1 commit into from
Oct 10, 2023

Conversation

akhilnarang
Copy link
Member

refactor: use mariadb commands and service instead of mysql

This resolves #1472

This has been done because the mysql command issues a deprecation warning now
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

@akhilnarang akhilnarang requested a review from ankush October 4, 2023 14:00
ankush
ankush requested changes Oct 10, 2023
View reviewed changes
bench/commands/setup.py Outdated
@@ -358,7 +358,7 @@ def sync_domains(domain=None, site=None):
@click.command("role", help="Install dependencies via ansible roles")
@click.argument("role")
@click.option("--admin_emails", default="")
@click.option("--mysql_root_password")
@click.option("--mariadb_root_password")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't change this, this can be breaking change for some scripts.

Add another alias for same flag? IIRC click does support that.

Copy link
Member Author

@akhilnarang akhilnarang Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, will do that.
Wanted to ask anyway, there's a lot of reference to MySQL in general in a few places like this, so for now should we leave them as-is or add secondary option with mariadb like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as aliases. Left variable names and dict keys intact so that it won't cause any issues.

@akhilnarang
refactor(treewide): use mariadb commands and service instead of `my…
8f3f1a4 
…sql`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akhilnarang akhilnarang requested a review from ankush October 10, 2023 08:22
@ankush ankush merged commit 96f1229 into frappe:develop Oct 10, 2023
13 checks passed
@bosue bosue mentioned this pull request Oct 10, 2023
Closed
@akhilnarang akhilnarang deleted the mysql-to-mariadb branch October 11, 2023 05:49
@github-actions
Copy link

🎉 This PR is included in version 5.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cogk cogk mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead
2 participants
@akhilnarang @ankush