Fix download timeout on node v20 install #2388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2332 for node v20, see #2332 (comment)
In node v20 the process hangs until the request times out caused by not consumed response data. Users might get the impression that the installation fails. This behavior is not observable for node v18, v16, v14, v12, v10.
From nodes docs:
This PR fixes the installation delay by adding
res.resume()
calls.How to reproduce:
Output for
is
for node v20, the times are