updates to change execute() to exec_create/exec_start #7
Conversation
1. works under python2 2. network module uses /proc/net/dev for statistics, which should always work 3. ggtools#2 gets around images that don't have ifconfig installed
|
Fixes #1 |
When using docker-py 1.8.0 (released on Apr 6 2016), this script can generate the error message about client API version being newer than server (1.22 / 1.21). The fix for this, according to [here](docker/docker-py#1032) is to specify the version or do specify 'auto' to use the server version. I've added `--version` as a keyword argument before the positional arguments for Client.
|
Latest commits add support for docker-py Any reason why you're ignoring my PRs? |
|
Sorry @oskapt just been busy and then forget to get back to it. Let me have a look |
|
Just a question: you change the shebang to use python instead of python3 which means it could be python2 in this cas, the print( will work but adding a |
|
I don't run python3 anywhere, so that was a quick hack back in October just to get things to work. I'm not up to speed on how best to get the two to play nice with each other. Does it really matter if it might run under python2? Specifying python3 in the shebang breaks it for environments where 3 isn't installed. I thought |
docker-pyno longer supportsc.execute()- it has been broken out intoc.exec_create()andc.exec_start(). This commit mostly covers that, and in the process solved a couple of other issues I encountered in my env. I've made the whole thing more generic and thus more flexible. It also works under Python2, so you can close out that issue from Feb./proc/net/devfor statistics, which should always workifconfiginstalled