Skip to content

Commit

Permalink
adress reviewer feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Sanyam Vikram committed Feb 21, 2024
1 parent c8ff1c6 commit 4cfc0db
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
## Description


This Github action identifies insecure configurations in Infrastructure as Code (IaC) files for Google Cloud resources. This action requires Terraform plan files in JSON format for scanning.
This GitHub action identifies insecure configurations in Infrastructure as Code (IaC) files for Google Cloud resources. This action requires Terraform plan files in JSON format for scanning.


Use this action to detect and remediate issues in IaC files for Google Cloud before you deploy the resources.
Expand All @@ -15,15 +15,13 @@ This action lets you:
- Display issues with their severity as a SARIF Report in the GitHub Workspace after a scan completes.
- Define severity-based failure criteria for passing or failing the build.

> [!IMPORTANT]
> This is a Security Command Center Premium tier offering for subscription customers only. You must activate the Security Command Center Premium tier in the Google Cloud organization to use this feature.
>
> This offering is covered by the Pre-GA Offerings Terms of the Google Cloud Terms of Service.
Note: This is a Security Command Center Premium tier offering for subscription customers only. You must activate the Security Command Center Premium tier in the Google Cloud organization to use this feature.


This offering is covered by the Pre-GA Offerings Terms of the Google Cloud Terms of Service.


Don’t enter any sensitive information such as passwords and other personal identifiable information in the Terraform plan files.

> [!CAUTION]
> Don’t enter any sensitive information such as passwords and other personal identifiable information in the Terraform plan files.
## Prerequisites

Expand Down Expand Up @@ -58,23 +56,24 @@ jobs:


- id: 'analyze-code-security-scc'
uses: 'google-github-actions/analyze-code-security-scc@v1'
uses: 'google-github-actions/analyze-code-security-scc@v0'
with:
organization_id: '123456789'
scan_file_ref: './tf_plan.json'
iac_type: terraform
iac_type: 'terraform'
iac_version: '1.0.0'
scan_timeout: '1m'
ignore_violations: false
failure_criteria: 'High:1,Medium:1,Low:1,Operator:or'
fail_silently: false


- if: ${{steps.analyze-code-security-scc.outputs.iac_scan_result_sarif_path != ''}}
uses: actions/upload-artifact@v4
- if: |-
steps.analyze-code-security-scc.outputs.iac_scan_result_sarif_path != ''
uses: 'actions/upload-artifact@v4'
with:
name: sarif
path: ${{ steps.analyze-code-security-scc.outputs.iac_scan_result_sarif_path }}
name: 'sarif'
path: '${{ steps.analyze-code-security-scc.outputs.iac_scan_result_sarif_path }}'
```
Expand Down Expand Up @@ -147,14 +146,14 @@ jobs:
- id: 'analyze-code-security-scc'
uses: 'google-github-actions/analyze-code-security-scc@v1'
uses: 'google-github-actions/analyze-code-security-scc@v0'
```


## Supported asset types and policies


For information about supported asset types and policies, see IaC Validation - Supported assets and policies.
For information about supported asset types and policies, see [IaC Validation - Supported assets and policies](https://www.gstatic.com/cloud_security_posture/iac_validation_supported_assets_and_policies.pdf).


[sa]: https://cloud.google.com/iam/docs/creating-managing-service-accounts
Expand Down

0 comments on commit 4cfc0db

Please sign in to comment.