Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from v1alpha to v1 and removing the iac_version #22

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Migrating from v1alpha to v1 and removing the iac_version #22

merged 2 commits into from
Mar 15, 2024

Conversation

kishorekgarg
Copy link
Contributor

  1. Migrated from v1alpha endpoints to v1 endpoints for the GA release
  2. Removed the iac_version as that is not in use
  3. Fixed typos

@kishorekgarg kishorekgarg requested a review from a team as a code owner March 15, 2024 04:10
@kishorekgarg kishorekgarg changed the title Kishorekgarg/v1 endpoint and iac version Migrating from v1alpha to v1 and removing the iac_version Mar 15, 2024
@kishorekgarg
Copy link
Contributor Author

Closed the earlier PR as tests were failing because it was raised from the forked repo. Sorry for the inconvenience.

@kishorekgarg kishorekgarg merged commit 5b1c5aa into main Mar 15, 2024
5 checks passed
@kishorekgarg kishorekgarg deleted the kishorekgarg/v1_endpoint_and_iac_version branch March 15, 2024 16:42
@google-github-actions-bot google-github-actions-bot mentioned this pull request Mar 27, 2024
Merged
kishorekgarg pushed a commit that referenced this pull request Mar 28, 2024
@google-github-actions-bot
Release: v0.1.0 (#26)
eeab586 
## What's Changed
* Change test setup and enable no-violations IT by @adishagarwal in
#18
* security: bump undici from 5.28.2 to 5.28.3 by @dependabot in
#19
* usage documentation update by @sanyam803 in
#20
* Migrating from v1alpha to v1 and removing the iac_version by
@kishorekgarg in
#22
* Updating the usage example in the README by @kishorekgarg in
#24
* fix incorrect application of always to not cancelled by @kishorekgarg
in
#25

## New Contributors
* @dependabot made their first contribution in
#19
* @kishorekgarg made their first contribution in
#22

**Full Changelog**:
v0.0.1...6054e18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushant00 sushant00 sushant00 approved these changes

@verbanicm verbanicm verbanicm approved these changes

@sanyam803 sanyam803 Awaiting requested review from sanyam803

@adishagarwal adishagarwal Awaiting requested review from adishagarwal

@sethvargo sethvargo Awaiting requested review from sethvargo sethvargo is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishorekgarg @verbanicm @sushant00