This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One PR to (re)fix em all: #49, #64, #66, #87.
API around clamping and upscaling seems confusing for everyone, so here's proposal to fix this issue. Idea is to keep rgb color objects to represent values in a unified way and provide additional helpers to work with out-of-range values and scaling.
Core changes:
sRGBColor(255, 123, 50, is_upscaled=True)
becomessRGBColor.new_from_upscaled(255, 123, 50)
and
becomes:
Things to discus:
colormath/color_conversions.py
- In transformation chain math domain error occurs only for AdobeRGBColor and AppleRGBColor. Should it be documented? Seems like rgb clapping was added to fix #49, but as side effect we got contradiction with documentation and #87.