feat: accept deno.json as an argument #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRAKING CHANGE: `findImportMap` option is abandoned. `collect` automatically finds `deno.json` or `deno.jsonc` in the current working directory or its parent directories.
`collect` now accepts JSON files including import maps, such as `deno.json` and `deno.jsonc` as an argument.
Now Molt can update URLs in `deno.json` (import maps) directly, without reading actual code.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 87.39% 87.24% -0.15%
==========================================
Files 18 18
Lines 825 886 +61
Branches 125 136 +11
==========================================
+ Hits 721 773 +52
- Misses 104 113 +9 ☔ View full report in Codecov by Sentry. |
hasundue
force-pushed
the
131-accept-deno-json
branch
2 times, most recently
from
4d7d449 to
5edcc5f
Compare
Deno seemed to panic with preact@10.5.5: https://github.com/hasundue/molt/actions/runs/8118222422/job/22194403024?pr=135 Also with jsdelivr with other conditions: https://github.com/hasundue/molt/actions/runs/8151250714/job/22278840938?pr=136
Because it's slow and seems to make Deno panic. For example: https://github.com/hasundue/molt/actions/runs/8151298737/job/22278963037?pr=136
hasundue
force-pushed
the
131-accept-deno-json
branch
2 times, most recently
from
cbc9347 to
2082cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alltask aspre-commitcwdoptions tocollectdeno.jsonas an argumentregistry -in test namesdeno.jsonas an argumentjsr:imports in some test cases