Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve trailing slashes in import URLs #139

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

hasundue
Copy link
Owner

@hasundue hasundue commented Mar 6, 2024

  • refactor(lib): normalize unversioned dependencies
  • refactor(lib): an option to enable/disable cache
  • test(lib): remove a trailing slash from redirect
  • fix: preserve trailing slashes in import URLs

@hasundue hasundue changed the title fix trailing slash fix: preserve trailing slashes in import URLs Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.40%. Comparing base (5f0f698) to head (6d2366d).

Files Patch % Lines
lib/dependency.ts 91.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   87.34%   87.40%   +0.05%     
==========================================
  Files          18       18              
  Lines         893      913      +20     
  Branches      139      146       +7     
==========================================
+ Hits          780      798      +18     
- Misses        113      115       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasundue hasundue force-pushed the fix-trailing-slash branch 2 times, most recently from 6263991 to 29cbde6 Compare March 6, 2024 09:02
@hasundue hasundue force-pushed the fix-trailing-slash branch from 29cbde6 to 6d2366d Compare March 6, 2024 09:09
@hasundue hasundue merged commit 156fbf1 into main Mar 6, 2024
7 checks passed
@hasundue hasundue deleted the fix-trailing-slash branch March 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant