Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve mapped jsr with path correctly #145

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

hasundue
Copy link
Owner

  • chore(cli): add --debug option
  • chore: better error message for unresolved import
  • test: add a failing case (mapped jsr with path)

@hasundue hasundue changed the title fix expected undefined fix: resolve mapped jsr with path correctly Mar 12, 2024
@hasundue hasundue force-pushed the fix-expected-undefined branch from 9616921 to d3d386e Compare March 12, 2024 04:38
@hasundue hasundue force-pushed the fix-expected-undefined branch from c490ce0 to b151d9d Compare May 8, 2024 06:48
@hasundue hasundue force-pushed the fix-expected-undefined branch from b151d9d to fb45d48 Compare May 8, 2024 11:18
Using a patched version of denoland/import_map
@hasundue hasundue force-pushed the fix-expected-undefined branch from 8244f38 to fe66ed3 Compare May 9, 2024 13:11
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 84.79%. Comparing base (d254e48) to head (f8c300c).

Files Patch % Lines
core/update.ts 0.00% 5 Missing ⚠️
core/dependency.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   85.30%   84.79%   -0.51%     
==========================================
  Files          10       10              
  Lines        1184     1197      +13     
  Branches      209      212       +3     
==========================================
+ Hits         1010     1015       +5     
- Misses        172      180       +8     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasundue hasundue force-pushed the fix-expected-undefined branch from fe66ed3 to 6af70c9 Compare May 9, 2024 14:52
@hasundue hasundue marked this pull request as ready for review May 10, 2024 02:51
@hasundue hasundue force-pushed the fix-expected-undefined branch from 0fffda1 to f8c300c Compare May 10, 2024 02:55
@hasundue hasundue merged commit 8bb9a32 into main May 10, 2024
5 of 7 checks passed
@hasundue hasundue deleted the fix-expected-undefined branch May 10, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant