fix(core): handle identical dependencies correctly #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasundue
changed the title
This fixes a problematic behavior when identical dependencies with and without range specifiers, such as ^, ~, or x. For example, if we have `jsr:@std/testing@^0.210.0` and `jsr:@std/testing@0.210.0/bdd` at the same time, both are updated to the latest version, or neither is updated, which should not happen.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 84.79% 84.96% +0.16%
==========================================
Files 10 10
Lines 1197 1197
Branches 212 212
==========================================
+ Hits 1015 1017 +2
+ Misses 180 178 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
hasundue
force-pushed
the
fix-jsr-import-map
branch
from
b11a913 to
b466f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problematic behavior when identical dependencies with and without range specifiers, such as ^, ~, or x. For example, if we have
jsr:@std/testing@^0.210.0andjsr:@std/testing@0.210.0/bddat the same time, both are updated to the latest version, or neither is updated, which should not happen.