21000: Fixes performance bug in string interning (#189)

howsoai · Jul 22, 2024 · 636a874 · 636a874
1 parent 7e7786d
commit 636a874
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Amalgam/string/StringInternPool.h b/src/Amalgam/string/StringInternPool.h
@@ -306,9 +306,10 @@ class StringInternPool
 
 			//one is static, destroy the other
 			if(sid_1_static)
-				DestroyStringReference(sid_2_static);
+				DestroyStringReference(sid_2);
 			else
-				DestroyStringReference(sid_1_static);
+				DestroyStringReference(sid_1);
+			return;
 		}
 
 		std::array<StringID, 2> string_ids = { sid_1, sid_2 };