Skip to content

Commit

Permalink
19404: Improves reliability of release notes (#117)
Browse files Browse the repository at this point in the history
Fixes an intermittent issue where the release notes that appear in the
body of GitHub releases include PR titles from older commits. We have
ditched the 3rd party release notes generator we were using in favor of
a new one + some proprietary code in our centralized workflow
repository.
  • Loading branch information
apbassett authored Apr 12, 2024
1 parent 6d43623 commit cba3d15
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,21 @@ jobs:
npm install
npm run test
generate-changelog:
if: inputs.build-type == 'release'
secrets: inherit
needs:
- smoke-test-linux-amd64
- smoke-test-linux-arm64
- smoke-test-linux-arm64_8a
- smoke-test-macos-amd64
- smoke-test-macos-amd64-large
- smoke-test-macos-amd64-on-arm64
- smoke-test-macos-arm64
- smoke-test-windows-amd64
- smoke-test-wasm64
uses: "howsoai/.github/.github/workflows/release-notes.yml@main"

release:
if: inputs.build-type == 'release'
needs:
Expand All @@ -430,6 +445,7 @@ jobs:
- smoke-test-macos-arm64
- smoke-test-windows-amd64
- smoke-test-wasm64
- generate-changelog
runs-on: ubuntu-latest
steps:

Expand All @@ -443,7 +459,7 @@ jobs:
commit: ${{ github.sha }}
name: "Amalgam ${{ inputs.version }}"
artifactErrorsFailBuild: true
generateReleaseNotes: true
body: ${{ needs.generate-changelog.outputs.changelog }}
makeLatest: legacy
artifacts: amalgam-*/amalgam-*.tar.gz
artifactContentType: application/gzip
artifactContentType: application/gzip

0 comments on commit cba3d15

Please sign in to comment.