Skip to content

Commit

Permalink
22353: Fixes an issue where warnings regarding analyses using case_we…
Browse files Browse the repository at this point in the history
…ights were given incorrectly (#371)

In a previous change the `paramPath` structure of hyperparameter maps
were changed and now the weight feature is not always in the same index,
but it should always be the last item.
  • Loading branch information
cademack authored Dec 3, 2024
1 parent 7d1b720 commit 35bd474
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion howso/conviction.amlg
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
))

;warn if specified weight_feature hasn't been analyzed
(and use_case_weights (!= weight_feature (get hyperparam_map (list "paramPath" 2))))
(and use_case_weights (!= weight_feature (last (get hyperparam_map "paramPath"))))
(accum (assoc
warnings
(associate (concat
Expand Down
2 changes: 1 addition & 1 deletion howso/react_discriminative.amlg
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
(call !UpdateCaseWeightParameters)

;warn if specified weight_feature hasn't been analyzed
(if (and use_case_weights (!= weight_feature (get hyperparam_map (list "paramPath" 3))))
(if (and use_case_weights (!= weight_feature (last (get hyperparam_map "paramPath"))))
(accum (assoc
warnings
(associate (concat
Expand Down

0 comments on commit 35bd474

Please sign in to comment.