Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: add metadata together with process initilization #1818

Merged

Conversation

bekiroguz
Copy link
Collaborator

This pull request includes several changes to enhance metadata handling and improve code readability in the akka-runtime module. The most important changes include adding metadata support to the CreateProcess message and refactoring the bake method.
These changes collectively improve the handling of process metadata during initialize phase and enhance the readability and maintainability of the codebase.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.49%. Comparing base (4155717) to head (861f0ba).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala 88.88% 1 Missing ⚠️
...r/runtime/serialization/InteractionExecution.scala 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1818      +/-   ##
==========================================
+ Coverage   79.42%   79.49%   +0.06%     
==========================================
  Files         144      144              
  Lines        5016     5032      +16     
  Branches      682      683       +1     
==========================================
+ Hits         3984     4000      +16     
  Misses       1032     1032              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tim-Linschoten Tim-Linschoten merged commit 49416a8 into master Jan 9, 2025
8 checks passed
@Tim-Linschoten Tim-Linschoten deleted the bugfix/add-metadata-together-with-process-initilization branch January 9, 2025 10:54
@bekiroguz bekiroguz added the bug label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants