setting to exclude MDC keys from being sent to Elastic #57
Conversation
useful when a particular key (or keys) may contain a lot of text that is of no particular use in your Elastic index, or when you want to explicitly add the key as an object property keys are matched case sensitive, without wildcard support
|
It would help us to exclude some MDC keys which conflict with some logback properties. Is there a plan to merge it ? |
| } | ||
| } | ||
| return result; |
There was a problem hiding this comment.
Is there a reason this list is re-allocated and populated anew every time a log entry is written? Why is this not parsed once when reading the config and then re-used on subsequent accesses? Looks like this could incur a performance overhead.
List instead of a map or set is probably fine, because this will likely only matter when there are hundreds of items in the collection and calculating the hash code of each tested key can be avoided.
| import com.internetitem.logback.elasticsearch.util.*; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.*; |
There was a problem hiding this comment.
New to the project, but I don't think star-imports are used anywhere else (and haven't been used before in this file).
useful when a particular key (or keys) may contain a lot of text that is of no particular use in your Elastic index, or when you want to explicitly add the key as an object property (see PR #56 for that)
keys are matched case sensitive, without wildcard support