Expect failures on CI

jacebrowning · Nov 11, 2023 · d4ac215 · d4ac215
1 parent de90754
commit d4ac215
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -17,15 +17,7 @@
     "site/": true,
     "geckodriver.log": true
   },
-  "python.pythonPath": ".venv/bin/python",
   "editor.formatOnSave": true,
-  "python.linting.enabled": true,
-  "python.linting.pylintEnabled": true,
-  "python.linting.pylintArgs": ["--rcfile", ".pylint.ini"],
-  "python.linting.mypyEnabled": true,
-  "python.linting.pydocstyleEnabled": true,
-  "python.formatting.provider": "black",
-  "python.formatting.blackPath": ".venv/bin/black",
   "cSpell.words": [
     "autopage",
     "chromedriver",

diff --git a/tests/test_api.py b/tests/test_api.py
@@ -22,7 +22,9 @@ def it_launches_a_browser(expect):
         page = pomace.visit("http://example.com", browser="chrome", headless=True)
         expect(page).contains("Example Domain")
 
-    @pytest.mark.skipif(os.name == "nt", reason="Path differs on Windows")
+    @pytest.mark.xfail(
+        os.name == "nt", raises=AssertionError, reason="Path differs on Windows"
+    )
     def it_saves_data_relative_to_caller(expect):
         page = pomace.visit("http://example.com", browser="chrome", headless=True)
         path = Path(__file__).parent / "sites" / "example.com" / "@" / "default.yml"

diff --git a/tests/test_sites.py b/tests/test_sites.py
@@ -24,7 +24,9 @@ def test_locator_uses_are_persisted(expect, browser):
     expect(bad_locator.uses) <= 0
 
 
-@pytest.mark.skipif("CI" in os.environ, reason="Wikipedia is blocked on CI")
+@pytest.mark.xfail(
+    "CI" in os.environ, raises=AssertionError, reason="Wikipedia is blocked on CI"
+)
 def test_type_actions_are_supported(expect, browser):
     page = Page.at("https://www.wikipedia.org")
 
@@ -34,7 +36,9 @@ def test_type_actions_are_supported(expect, browser):
     expect(shared.client.url).endswith("wikipedia.org/wiki/Foobar")
 
 
-@pytest.mark.skipif("CI" in os.environ, reason="Wikipedia is blocked on CI")
+@pytest.mark.xfail(
+    "CI" in os.environ, raises=AssertionError, reason="Wikipedia is blocked on CI"
+)
 def test_modifier_keys_are_supported(expect, browser):
     page = Page.at("https://www.wikipedia.org")