Use SecKeychainCopyDomainSearchList to find system keychain #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-adder
bot
requested review from
aprueher,
BartO-jamf,
c7bercat,
camdenwebster,
CassieJamf,
jjpritzl,
johnlehouerou,
macshome,
paulinaurbass and
RachelPolachova
team-adder
bot
requested review from
johnlehouerou,
tsfischer,
macshome,
jjpritzl,
watkyn,
paulinaurbass,
RachelPolachova,
rydgecrakerjamf,
Saczuu,
shalomOwolabi,
teeweizhong10 and
Tendai06
macblazer
approved these changes
Jan 5, 2024
Tendai06
approved these changes
Jan 8, 2024
paulinaurbass
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been mentioned on the forums that hardcoding a path to the system keychain may not be ideal. This PR addresses that by using the Security frameworks methods to locate the system keychain. To retain compatibility any errors from attempting to locate the system keychain will default to previous behavior and return a reference to
KeychainFilethat will attempt to find the system keychain at/Library/Keychains/System.keychain.