[fixup] pass by const reference && do not pass void to method

labwc · Apr 27, 2024 · 2816618 · 2816618
1 parent bb874e6
commit 2816618
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tweaks-qt/layoutmodel.cpp b/tweaks-qt/layoutmodel.cpp
@@ -30,7 +30,7 @@ LayoutModel::LayoutModel(QObject *parent) : QAbstractListModel(parent)
 
 LayoutModel::~LayoutModel() { }
 
-char *LayoutModel::getXkbDefaultLayout(void)
+char *LayoutModel::getXkbDefaultLayout()
 {
     QString ret;
     QVectorIterator<QSharedPointer<Layout>> iter(m_layouts);
@@ -69,7 +69,7 @@ void LayoutModel::update(void)
     emit dataChanged(topLeft, topLeft, { Qt::DisplayRole });
 }
 
-void LayoutModel::addLayout(QString code, QString desc)
+void LayoutModel::addLayout(const QString &code, const QString &desc)
 {
     QVectorIterator<QSharedPointer<Layout>> iter(m_layouts);
     while (iter.hasNext()) {

diff --git a/tweaks-qt/layoutmodel.h b/tweaks-qt/layoutmodel.h
@@ -26,9 +26,9 @@ class LayoutModel : public QAbstractListModel
 
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
-    void addLayout(QString code, QString desc);
+    void addLayout(const QString &code, const QString &desc);
     void deleteLayout(int index);
-    char *getXkbDefaultLayout(void);
+    char *getXkbDefaultLayout();
 
 private:
     void update(void);