Skip to content

Commit

Permalink
Install optional dev dependencies (#95)
Browse files Browse the repository at this point in the history
See mesh-adaptation/animate#167 (and related
Goalie/Movement/UM2N/opt-adapt PRs linked therein).
  • Loading branch information
ddundo authored Jan 2, 2025
1 parent 10a54d3 commit b1b3e6f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/test_firedrake_install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: 'Install Firedrake'
run: |
yes | make install
cd firedrake-*
cd firedrake-*/
echo "FIREDRAKE_ENV=$(pwd)" >> $GITHUB_ENV
- name: 'Upload firedrake-install.log as an artifact'
Expand All @@ -65,7 +65,7 @@ jobs:
cd $FIREDRAKE_ENV/src
git clone https://github.com/mesh-adaptation/animate.git
cd animate
make install
make install_dev
make test
- name: 'Install and test Goalie'
Expand All @@ -75,7 +75,7 @@ jobs:
cd $FIREDRAKE_ENV/src
git clone https://github.com/mesh-adaptation/goalie.git
cd goalie
make install
make install_dev
make test
- name: 'Install and test Movement'
Expand All @@ -85,5 +85,5 @@ jobs:
cd $FIREDRAKE_ENV/src
git clone https://github.com/mesh-adaptation/movement.git
cd movement
make install
make install_dev
make test
6 changes: 3 additions & 3 deletions docker/Dockerfile.firedrake-parmmg
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,6 @@ RUN curl -O https://raw.githubusercontent.com/firedrakeproject/firedrake/master/
git clone https://github.com/mesh-adaptation/animate.git && \
git clone https://github.com/mesh-adaptation/movement.git && \
git clone https://github.com/mesh-adaptation/goalie.git && \
cd animate && make install && \
cd ../movement && make install && \
cd ../goalie && make install"
cd animate && make install_dev && \
cd ../movement && make install_dev && \
cd ../goalie && make install_dev"
2 changes: 1 addition & 1 deletion docker/Dockerfile.firedrake-um2n
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN bash -c "source firedrake/bin/activate && \
cd firedrake/src && \
git clone https://github.com/mesh-adaptation/UM2N.git && \
python3 -m pip uninstall cffconvert -y && \
python3 -m pip install -e UM2N"
python3 -m pip install -e UM2N[dev]"

# NOTE: cffconvert is not currently used in UM2N and requires a conflicting
# version of jsonschema with other dependencies.

0 comments on commit b1b3e6f

Please sign in to comment.