Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid importing from firedrake.__future__ #272

Open
jwallwork23 opened this issue Dec 24, 2024 · 2 comments · Fixed by #266
Open

Avoid importing from firedrake.__future__ #272

jwallwork23 opened this issue Dec 24, 2024 · 2 comments · Fixed by #266
Labels
clarity Something isn't sufficiently clear

Comments

@jwallwork23
Copy link
Member 

          Thanks! It would be neater to use `Function(fs).interpolate(...)` rather than `assemble(firedrake.__future__interpolate(...))` but that's for another PR I guess :)

Originally posted by @ddundo in #271 (review)
@jwallwork23 jwallwork23 added the clarity Something isn't sufficiently clear label Dec 24, 2024
This was referenced Dec 24, 2024
Merged
Merged
@ddundo
Copy link
Member

ddundo commented Dec 24, 2024

I don't think this should have been closed? Or you decided against it?

@jwallwork23
Copy link
Member Author

Oops good point, I referenced the wrong issue.

@jwallwork23 jwallwork23 reopened this Dec 24, 2024
@ddundo ddundo moved this from Done to Backlog in Mesh Adaptation development board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarity Something isn't sufficiently clear
Projects
Mesh Adaptation development board
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop lint ignores except in demos mesh-adaptation/goalie
2 participants
@jwallwork23 @ddundo