Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid polluting Goalie namespace #271

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

jwallwork23
Copy link
Member

Closes #270.

This PR ensures all modules define __all__ and stops goalie.__init__ from importing anything outside of Goalie itself.

Only one code change is required, for an from firedrake.__future__ import interpolate import. Everything else is just formatting.

@jwallwork23 jwallwork23 added the bug Something isn't working label Dec 24, 2024
@jwallwork23 jwallwork23 self-assigned this Dec 24, 2024
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be neater to use Function(fs).interpolate(...) rather than assemble(firedrake.__future__interpolate(...)) but that's for another PR I guess :)

@jwallwork23 jwallwork23 merged commit 4c42130 into 265_drop-ignores Dec 24, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 270_no-pollution branch December 24, 2024 12:10
@jwallwork23
Copy link
Member Author

Thanks! It would be neater to use Function(fs).interpolate(...) rather than assemble(firedrake.__future__interpolate(...)) but that's for another PR I guess :)

Opened #272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants