Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple ODE demo #101

Merged
merged 15 commits into from
Feb 28, 2024
Merged

Add simple ODE demo #101

merged 15 commits into from
Feb 28, 2024

Conversation

jwallwork23
Copy link
Member

Closes #100.

Also introduces a new PointSeq class for use with ODE problems.

@jwallwork23 jwallwork23 added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 1, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Feb 1, 2024
@jwallwork23 jwallwork23 self-assigned this Feb 1, 2024
@jwallwork23
Copy link
Member Author

Test suite seems to be failing for the same reason currently under investigation in #104.

@jwallwork23 jwallwork23 marked this pull request as ready for review February 20, 2024 18:46
@jwallwork23 jwallwork23 requested a review from ddundo February 20, 2024 18:46
@jwallwork23
Copy link
Member Author

@ddundo Since you mentioned you'd already been looking at this, would you be happy to review it?

ddundo
ddundo approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice @jwallwork23! Left a few small comments :)

goalie/point_seq.py Outdated Show resolved Hide resolved
demos/ode.py Outdated Show resolved Hide resolved
demos/ode.py Outdated Show resolved Hide resolved
demos/ode.py Outdated Show resolved Hide resolved
demos/ode.py Outdated Show resolved Hide resolved
demos/ode.py Outdated Show resolved Hide resolved
demos/ode.py Outdated Show resolved Hide resolved
@jwallwork23 jwallwork23 requested a review from ddundo February 28, 2024 09:00
@jwallwork23
Copy link
Member Author

Thanks for the review @ddundo. I think I addressed all your concerns. Also used float(sol) instead of sol.dat.data[0] for simplicity and to avoid exposing underlying Firedrake data structures in an early demo.

@ddundo
Copy link
Member

ddundo commented Feb 28, 2024

Thanks @jwallwork23, I think this is much clearer now!

@jwallwork23 jwallwork23 merged commit 6c32ae9 into main Feb 28, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 100_ode branch February 28, 2024 09:24
@jwallwork23 jwallwork23 mentioned this pull request Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddundo ddundo Awaiting requested review from ddundo

Assignees

@jwallwork23 jwallwork23

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Goalie-v1.0
Development

Successfully merging this pull request may close these issues.

Add ODE demo
2 participants
@jwallwork23 @ddundo