Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTK API update #131

Merged
merged 1 commit into from
Mar 7, 2024
Merged

VTK API update #131

merged 1 commit into from
Mar 7, 2024

Conversation

jwallwork23
Copy link
Member

Closes #130.

@ddundo this is currently stopping #128 tests from passing. Once merged into main, you should merge main into your branch and see if the test suite passes.

@jwallwork23 jwallwork23 added the bug Something isn't working label Mar 7, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Mar 7, 2024
@jwallwork23 jwallwork23 requested a review from ddundo March 7, 2024 10:51
@jwallwork23 jwallwork23 self-assigned this Mar 7, 2024
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe! I'll do that :)

@jwallwork23 jwallwork23 merged commit 8120037 into main Mar 7, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 130_vtkfile branch March 7, 2024 11:15
ddundo pushed a commit that referenced this pull request Mar 16, 2024
Closes #130.

File has been renamed VTKFile on the Firedrake side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VTK API update
2 participants