Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use idx kwarg in CheckpointFile when exporting #227

Merged
merged 27 commits into from
Nov 2, 2024
Merged

Use idx kwarg in CheckpointFile when exporting #227

merged 27 commits into from
Nov 2, 2024

Conversation

ddundo
Copy link
Member

@ddundo ddundo commented Nov 1, 2024

Minor addition to #221. I just saw that CheckpointFile.save_function can be provided an idx for timestepping.

Ah I restored the deleted branch so the commit history is messy! But it's just the small final commit that's new.

@ddundo ddundo requested a review from jwallwork23 November 1, 2024 22:55
@ddundo ddundo self-assigned this Nov 1, 2024
@ddundo ddundo added the enhancement New feature or request label Nov 1, 2024
Copy link
Member

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Don't worry about having a messy commit history - this is one of the reasons we are enforcing squash merging of PRs.

@ddundo ddundo merged commit c50074e into main Nov 2, 2024
1 check passed
@ddundo ddundo deleted the 117_export branch November 2, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants