Framework for QoI optimisation #251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #245.
This PR sets up several classes to support PDE-constrained optimisation in Goalie as an outer loop process (outside the fixed-point iterations, even). The difference between these optimisation methods and those already available in Pyadjoint is that they will support adaptive meshes.
Eventually, we will implement gradient descent, Adam, Newton, BFGS, and L-BFGS, which were already implemented in https://github.com/mesh-adaptation/opt_adapt. In this PR, we just add
OptimisationParametersoptions class to hold tolerances, maxiter, etc.QoIOptimiser_Base, which will implement the minimisation strategy, as well as line searching (upstreamed from opt_adapt).QoIOptimiser_Base.QoIOptimiser, which allows the subclasses to be easily constructed.