Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework enforce_element_constraints #56

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Rework enforce_element_constraints #56

merged 7 commits into from
Apr 4, 2024

Conversation

jwallwork23
Copy link
Member

@jwallwork23 jwallwork23 commented Sep 15, 2023 •
edited
Loading

Closes #12.
See PR mesh-adaptation/animate#38.

Here we rename enforce_element_constraints as enforce_variable_constraints and make use of the new functionality in Animate.

Tests still need to be added.

@jwallwork23 jwallwork23 self-assigned this Sep 15, 2023
@jwallwork23 jwallwork23 force-pushed the 12_enforce_variable_constraints branch from ef26010 to 9ce3af1 Compare February 28, 2024 10:24
@jwallwork23 jwallwork23 force-pushed the 12_enforce_variable_constraints branch from 9ce3af1 to e408553 Compare March 4, 2024 13:14
@jwallwork23 jwallwork23 marked this pull request as ready for review March 4, 2024 13:14
@jwallwork23
Copy link
Member Author

Partially addresses #121.

@jwallwork23 jwallwork23 requested a review from ddundo March 4, 2024 13:15
@jwallwork23 jwallwork23 added the refactor A suggested reworking of the code label Mar 4, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Mar 4, 2024
@jwallwork23
Copy link
Member Author

Sorry @ddundo, I requested your review on this but then realised I hadn't added any tests for the new functionality. Will look into it and then get back to you.

@jwallwork23
Copy link
Member Author

Okay it's now ready for review @ddundo

@jwallwork23 jwallwork23 mentioned this pull request Mar 8, 2024
Merged
@jwallwork23
Copy link
Member Author

Would you mind taking a look at this @ddundo? The changes should be fairly non-controversial.

ddundo
ddundo requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jwallwork23, I forgot about this! Looks good, but I had some tests fail locally so I re-ran the CI and got the same here.

@jwallwork23
Copy link
Member Author

Sorry @jwallwork23, I forgot about this! Looks good, but I had some tests fail locally so I re-ran the CI and got the same here.

I just merged in main so hopefully that fixes things.

@ddundo
Copy link
Member

ddundo commented Apr 4, 2024

@jwallwork23 sorry, I don't know if you were waiting for a response from me here :) it looks good to me now!

@jwallwork23
Copy link
Member Author

@jwallwork23 sorry, I don't know if you were waiting for a response from me here :) it looks good to me now!

Please can you approve? Otherwise I can't merge.

@jwallwork23 jwallwork23 requested a review from ddundo April 4, 2024 09:24
ddundo
ddundo approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@jwallwork23 jwallwork23 merged commit de2d00e into main Apr 4, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 12_enforce_variable_constraints branch April 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddundo ddundo ddundo approved these changes

Assignees

@jwallwork23 jwallwork23

Labels
refactor A suggested reworking of the code
Projects
None yet
Milestone
Goalie-v1.0
Development

Successfully merging this pull request may close these issues.

Refactor enforce_element_constraints
2 participants
@jwallwork23 @ddundo