Testing for goal-oriented error estimation code #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
the
testing
jwallwork23
force-pushed
the
68_go_test
branch
from
f224acd to
13215d3
Compare
jwallwork23
force-pushed
the
68_go_test
branch
from
9bc34f6 to
3216fde
Compare
stephankramer
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68. Partially addresses #42.
The main aim of this PR is to get
go_mesh_seq.pyunder the test harness so that we can tackle #55. It goes as far as covering all of the code except the bit that issue addresses. In a future PR, we will introduce a broken test for that part and then fix it.This PR also moves
indicators2estimatorfrom being a function defined inerror_estimation.pyto being a method ofGoalOrientedMeshSeq. This felt natural because it only has a single call site, in that class'fixed_point_iterationmethod.The
global_enrichmentmethod ofGoalOrientedMeshSeqis dropped as it is unused.