Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mesh tangling checker #103

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Use mesh tangling checker #103

merged 8 commits into from
Jul 4, 2024

Conversation

jwallwork23
Copy link
Member

@jwallwork23 jwallwork23 commented Jun 28, 2024

Closes #101.

This PR hooks up the MeshTanglingChecker to the mover classes and turns it on by default in the 2D case. This will stop subtly tangled meshes from eluding detection.

@jwallwork23 jwallwork23 added the bug Something isn't working label Jun 28, 2024
@jwallwork23 jwallwork23 self-assigned this Jun 28, 2024
@jwallwork23 jwallwork23 requested a review from erizmr July 4, 2024 09:53
Copy link
Collaborator

@erizmr erizmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jwallwork23 jwallwork23 merged commit 04276c1 into main Jul 4, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 101_tangling_check branch July 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Use mesh tangling checker
2 participants