Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update citations for html #132

Merged
merged 2 commits into from
Nov 19, 2024
Merged

update citations for html #132

merged 2 commits into from
Nov 19, 2024

Conversation

acse-ej321
Copy link
Collaborator

@acse-ej321 acse-ej321 commented Nov 18, 2024

Linked to mesh-adaptation/docs#50

should be evaluated in combination with:
mesh-adaptation/docs#50
mesh-adaptation/animate#160
mesh-adaptation/goalie#232

Locally the main warning remaining after all the PRs should be about 'duplicate_citations', though all citations should still render.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, don't we want to remove this bibtex file and just use the one in the docs repo?

Copy link
Collaborator Author

@acse-ej321 acse-ej321 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the demo_references.bib file in each of the ./demos folders and updated the Makefile to copy each into the one in the docs repo which is the collective reference. The logic for including maintaining a demo_references.bib I think would be the convenience of adding any future demos and references to the same repository.
It would simplify the file structure even more to just add them to the one in docs repo - so will do that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry that I didn't suggest this earlier!

Copy link
Member

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citations seem to work for Movement when I build locally, thanks.

acse-ej321 added a commit to mesh-adaptation/goalie that referenced this pull request Nov 19, 2024
Linked to
mesh-adaptation/docs#50

should be evaluated in combination with:
mesh-adaptation/docs#50
mesh-adaptation/animate#160
mesh-adaptation/movement#132

Locally the main warning remaining after all the PRs should be about
'duplicate_citations', though all citations should still render.
@acse-ej321 acse-ej321 merged commit c3bbd9c into main Nov 19, 2024
1 check passed
@acse-ej321 acse-ej321 deleted the docs-ref-update branch November 19, 2024 09:22
acse-ej321 added a commit to mesh-adaptation/animate that referenced this pull request Dec 6, 2024
Linked to
mesh-adaptation/docs#50

should be evaluated in combination with:
mesh-adaptation/docs#50
mesh-adaptation/goalie#232
mesh-adaptation/movement#132

Locally the main warning remaining after all the PRs should be about
'duplicate_citations', though all citations should still render.
acse-ej321 added a commit to mesh-adaptation/docs that referenced this pull request Dec 6, 2024
closes #50 

should be evaluated in combination with:
mesh-adaptation/movement#132
mesh-adaptation/animate#160
mesh-adaptation/goalie#232

Locally the main warnings remaining after all the PRs should be about
'duplicate_citations', though all citations should still render.

---------

Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com>
Co-authored-by: acse-ej321 <acse-ej321@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants