Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to comp coords before moving with QN #147

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Switch to comp coords before moving with QN #147

merged 2 commits into from
Jan 9, 2025
+3 −0

Conversation

ddundo
Copy link
Member

@ddundo ddundo commented Jan 8, 2025

Closes #146.

I think only this was needed. Using method="relaxation" works as expected

@ddundo ddundo requested a review from jwallwork23 January 8, 2025 22:21
@ddundo ddundo self-assigned this Jan 8, 2025
@ddundo ddundo added bug Something isn't working PRIORITY We should address this ASAP labels Jan 8, 2025
jwallwork23
jwallwork23 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good spot! I could've sworn we fixed this recently but apparently not.

@ddundo ddundo merged commit 69e4121 into main Jan 9, 2025
1 check passed
@ddundo ddundo deleted the 146_bug-when-moving-twice branch January 9, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwallwork23 jwallwork23 jwallwork23 approved these changes

Assignees

@ddundo ddundo

Labels
bug Something isn't working PRIORITY We should address this ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving an already-optimised mesh doesn't converge immediately
2 participants
@ddundo @jwallwork23