Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic Monge-Ampere demo #28

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Add basic Monge-Ampere demo #28

merged 8 commits into from
Jan 12, 2024

Conversation

jwallwork23
Copy link
Member

Partially addresses #26.

Also add test_demos.py to check that the new demo runs.

@jwallwork23 jwallwork23 added documentation Improvements or additions to documentation testing Extensions and improvements to the testing infrastructure labels Jan 12, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Jan 12, 2024
@jwallwork23 jwallwork23 self-assigned this Jan 12, 2024
@jwallwork23 jwallwork23 mentioned this pull request Jan 12, 2024
Merged
@jwallwork23 jwallwork23 marked this pull request as ready for review January 12, 2024 09:15
@jwallwork23
Copy link
Member Author

Looks good when tested in mesh-adaptation/mesh-adaptation.github.io#21.

stephankramer
stephankramer approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@stephankramer stephankramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe. Works perfectly. Are we going to add this to the website now as well? I guess we need some mechanism to view the rendered sphinx

@jwallwork23
Copy link
Member Author

I was thinking of doing, yeah. It would probably be neater to have a landing page with a concise intro to the three packages, each with a link that will give you the full detail.

@jwallwork23 jwallwork23 merged commit 2062f12 into main Jan 12, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 26_monge_ampere_demo branch January 12, 2024 16:52
@jwallwork23 jwallwork23 mentioned this pull request Jan 12, 2024
Closed
@jwallwork23 jwallwork23 mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephankramer stephankramer stephankramer approved these changes

Assignees

@jwallwork23 jwallwork23

Labels
documentation Improvements or additions to documentation testing Extensions and improvements to the testing infrastructure
Projects
None yet
Milestone
Movement-v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jwallwork23 @stephankramer