Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for raising warning if not converged #92

Merged
merged 5 commits into from
Jun 9, 2024
Merged

Conversation

jwallwork23
Copy link
Member

Closes #86.

Does this option look like what you were asking for @erizmr?

We could make it more general and support it for all methods but I thought I'd just introduce it as a kwarg for move in the Monge-Ampere case for now.

@jwallwork23 jwallwork23 added the enhancement New feature or request label Jun 7, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Jun 7, 2024
@jwallwork23 jwallwork23 requested a review from erizmr June 7, 2024 07:32
@jwallwork23 jwallwork23 self-assigned this Jun 7, 2024
Copy link
Collaborator

@erizmr erizmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It looks good to me! Thanks!

@jwallwork23
Copy link
Member Author

Sorry, decided to be more thorough. How about this now?

@erizmr
Copy link
Collaborator

erizmr commented Jun 8, 2024

Sorry, decided to be more thorough. How about this now?

It looks more structural and informative than before!

@jwallwork23 jwallwork23 merged commit a6a00bf into main Jun 9, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 86_robust_mode branch June 9, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce "robust" mode
2 participants