Skip to content

0.6.1 - Code review cleanup

Compare
Choose a tag to compare
@ms3056 ms3056 released this 08 Jul 02:22

"authorUrl": "",
This should always be set, if you don't have a website use your GitHub profile.

completed

--background: #1c2732;
These variable names are too generic, you should make them unique to your plugin.
You should also see if you can find one of the inbuild variables for your case, if a user uses a community theme your plugin has a higher chance of adapting to it's color scheme.
https://docs.obsidian.md/Reference/CSS+variables/CSS+variables

completed, but did not use standard variables - instead made unique variables and then added Style Settings mechanism

font-family: "Roboto", sans-serif;
Same thing with your font here, and many of the paddings & margins.

Completed - removed

const checkLayoutInterval = setInterval(async () => {
This can be simplified to the below, no need to check on an interval:

completed - removed

this.app.workspace.onLayoutReady(async () => {
await this.initView();
});
const response = await axios.get(WEATHER_API_URL);
I would recommend using the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

completed