-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NATS Streaming Operator Helm Chart #39
Conversation
I like having a Helm Chart. thx @Starefossen !. Will try it out soon as I need to deploy and manage a nats-streaming cluster one way or another |
Will be this merged? |
subjects: | ||
- kind: ServiceAccount | ||
name: nats-streaming-operator | ||
namespace: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the better way to use:
namespace: {{.Release.Namespace}}
- name: readyz | ||
containerPort: 8080 | ||
{{- if .Values.livenessProbe.enabled }} | ||
livenessProbe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nats-streaming-operator does not have 8080 port into it's pod. So I had a problem with this livenessprobe.
Maybe it is a good way to add a new brunch for the helm-chart preparing. |
@Starefossen I have an open PR for your fork, if you get a moment to merge that in. It addresses a few of the concerns brought up, and I'm hoping that we can get this merged in. So far, it addresses:
|
@dellintosh thanks for the contribution, since there are some adopting the helm chart already I think we should merge as is and you can send PR here if you want. |
Thanks a lot @Starefossen for the PR, sorry for the delay in merging... 🙇 |
This Pull Request adds a Helm chart for the NATS Streaming Operator similar to the NATS Operator (https://github.com/nats-io/nats-operator/tree/master/helm/nats-operator)
All suggestions, comments and improvements are welcome. Also thinking if we should submit this to the official chart repository to make it easy to install without having to git clone the repo.
TODO:
OTHER: