Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NATS Streaming Operator Helm Chart #39

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

Starefossen
Copy link
Contributor

@Starefossen Starefossen commented Mar 25, 2019

This Pull Request adds a Helm chart for the NATS Streaming Operator similar to the NATS Operator (https://github.com/nats-io/nats-operator/tree/master/helm/nats-operator)

All suggestions, comments and improvements are welcome. Also thinking if we should submit this to the official chart repository to make it easy to install without having to git clone the repo.

TODO:

  • Document values.yaml in README.md
  • Uodate NOTES.txt

OTHER:

  • liveness and readiness for NATS Streaming Operator deployment (blocked on Enable monitoring #31)
  • Cluster Scoped install similar to the NATS Operator?
  • Add nats-operator as a dependency to auto-install NATS Operator?

@philicious
Copy link

I like having a Helm Chart. thx @Starefossen !. Will try it out soon as I need to deploy and manage a nats-streaming cluster one way or another

@tegk
Copy link

tegk commented Oct 2, 2019

Will be this merged?

subjects:
- kind: ServiceAccount
name: nats-streaming-operator
namespace: default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the better way to use:

namespace: {{.Release.Namespace}}

- name: readyz
containerPort: 8080
{{- if .Values.livenessProbe.enabled }}
livenessProbe:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nats-streaming-operator does not have 8080 port into it's pod. So I had a problem with this livenessprobe.

@omenv
Copy link

omenv commented Dec 23, 2019

Maybe it is a good way to add a new brunch for the helm-chart preparing.
Also good to see options for persistence/SQL.

@omenv omenv mentioned this pull request Dec 25, 2019
@dellintosh
Copy link
Contributor

dellintosh commented Jan 21, 2020

@Starefossen I have an open PR for your fork, if you get a moment to merge that in. It addresses a few of the concerns brought up, and I'm hoping that we can get this merged in.

So far, it addresses:

...
TODO:

  • Document values.yaml in README.md
  • Update NOTES.txt

OTHER:

  • liveness and readiness for NATS Streaming Operator deployment (blocked on Enable monitoring #31)
  • Cluster Scoped install similar to the NATS Operator?
  • Add nats-operator as a dependency to auto-install NATS Operator?
  • The dependencies require a Helm Chart Repository for the NATS Operator. Since there is no Chart Repo for that (it's just pulling from git when installing the chart), this is blocked by that. I'll see if I can take a shot at getting that set up though, so we can make sure that NATS Operator is set up as a dependency.

Starefossen#1

@wallyqs
Copy link
Member

wallyqs commented Jan 21, 2020

@dellintosh thanks for the contribution, since there are some adopting the helm chart already I think we should merge as is and you can send PR here if you want.

@wallyqs wallyqs marked this pull request as ready for review January 21, 2020 18:42
@wallyqs wallyqs merged commit f41172b into nats-io:master Jan 21, 2020
@wallyqs
Copy link
Member

wallyqs commented Jan 21, 2020

Thanks a lot @Starefossen for the PR, sorry for the delay in merging... 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants