Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for issue #720 #721

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Hotfix for issue #720 #721

merged 1 commit into from
Oct 23, 2024

Conversation

einola
Copy link
Member

@einola einola commented Oct 22, 2024

Hotfix for bug in issue #720

Fixes partially #720

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

I just reverted the offending comment and fixed a few formatting issues. But this should be done properly at some point.


Test Description

The dynamics benchmark runs. A carefully placed break point or std::cout confirms that the params class is properly set.


Documentation Impact

N/A


Other Details

N/A


Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • File dates have been updated to reflect modification date
  • This change conforms to the conventions described in the README

I just reverted the offending comment and fixed a few formatting issues.
But this should be done properly at some point.
@einola einola requested a review from timspainNERSC October 22, 2024 11:28
@einola einola added the bug Something isn't working label Oct 22, 2024
@einola einola merged commit c478cf4 into develop Oct 23, 2024
5 checks passed
@einola einola deleted the issue720_params_hotfix branch October 23, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants