Implement Xios handler as a singleton #763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2025
12 tasks
3 tasks
TomMelt
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks @jwallwork23, looks good to me. I have tested it locally and all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR merges into the branch for #757, not
develop.This PR implements the
Xioshandler object as a singleton, as requested. This means that nextSIM-DG classes don't need to own pointers to the current workingXiosinstance. There can be only oneXiosinstance. The first time the staticXios::getInstancemethod is called, it creates the singleton and returns a pointer to it. On subsequent calls, this method simply returns a pointer to the singleton.Unfortunately, I had to rework the XIOS read/write test. The singleton design pattern isn't suitable for the way it's currently written, so I re-separated out the reading and writing parts and re-combined the 2D and 3D cases.