added interactive mode, made quota optional #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- converted to POSIX Shell - moved initial variables to script body to follow prerequisite functions (prevents stderr messages ahead of these checks) - moved check_volume ahead of check_startup_disk - removed $sizeSuffix (since it was standardized on GB anyway) - removed $volumeIdentifier (unused since this script was split from encryption workflows)
- made quota optional (if undefined, new volume shares all available container space with startup disk)
- script now checks each Jamf Pro script parameter individually and prompts user for selection if missing - removed check_jamf_pro_arguments - newVolumeQuota defaults to "none" (share all container space) if undefined - removed startupDiskName and check_startup_disk (now detects startup volume name programmatically) - moved file system personality check to function - renamed script to clarify functionality - major version change (guess it's finally time)
- added quota percentage option - if both percentage and GB are defined, the larger value is selected - added quota removal flag (supersedes quota GB and quota percentage) - quota is also removed if quota GB exceeds disk capacity or if quota percentage is 100 - added check_startup_container_size() (verifies container size is readable before proceeding, then converts byte value to GB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_jamf_pro_arguments()check_startup_container_size()(verifies container size is readable before proceeding, then converts byte value to GB)$newVolumeQuotaPercent$newVolumeQuotaGBor$newVolumeQuotaPercent$removeQuotaflag (supersedes quota GB or percentage if defined)check_file_system_personality()$startupDiskNameandcheck_startup_disk()(now detects startup volume name programmatically)$sizeSuffix(since it was standardized on GB anyway)$volumeIdentifier(unused since this script was split from encryption workflows)