Release 0.2.1 #27
Release 0.2.1 #27
Conversation
# Conflicts: # docs/changelog.md
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 82.07% 82.67% +0.59%
==========================================
Files 12 12
Lines 463 479 +16
==========================================
+ Hits 380 396 +16
Misses 83 83
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
.github/workflows/ruff_linter.yml
Outdated
| @@ -0,0 +1,12 @@ | |||
| name: Ruff | |||
There was a problem hiding this comment.
Are we actually switching to ruff for all projects? We should probably discuss (briefly) at the next Infrastructure meeting.
There was a problem hiding this comment.
No, we're using black. don't switch this kind of thing please.
if you have a compelling case to switch, we should discuss, but then we'll switch all our projects.
| @@ -84,3 +88,18 @@ def call_client_func(func: Callable[..., Any], **kwargs) -> Any: | |||
| MessageHandler.print_warning(f"PEP already exists. {err}") | |||
| except OSError as err: | |||
| MessageHandler.print_error(f"{err}") | |||
|
|
|||
|
|
|||
| def is_registry_path(input_string: str) -> bool: | |||
There was a problem hiding this comment.
Something very similar exists in Looper. Should this, therefore, now be placed in ubiquerg along with parse_registry_path?
There was a problem hiding this comment.
No, this should be part of pephubclient, and looper should now use this function
| @@ -1,7 +1,9 @@ | |||
| black | |||
There was a problem hiding this comment.
If we use ruff, can we remove black?
Added function that checks correctness of registry path to helpers