Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Queue staff link if user can't approve images #200

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Hide Queue staff link if user can't approve images #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/philomena/images.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,15 @@ defmodule Philomena.Images do

defp maybe_suggest_user_verification(_user), do: false

def count_pending_approvals() do
Image
|> where(hidden_from_users: false)
|> where(approved: false)
|> Repo.aggregate(:count)
def count_pending_approvals(user) do
if Canada.Can.can?(user, :approve, %Image{}) do
liamwhite marked this conversation as resolved.
Show resolved Hide resolved
Image
|> where(hidden_from_users: false)
|> where(approved: false)
|> Repo.aggregate(:count)
else
nil
end
end

def feature_image(featurer, %Image{} = image) do
Expand Down
2 changes: 1 addition & 1 deletion lib/philomena_web/plugs/admin_counters_plug.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ defmodule PhilomenaWeb.AdminCountersPlug do
defp maybe_assign_admin_metrics(conn, _user, false), do: conn

defp maybe_assign_admin_metrics(conn, user, true) do
pending_approvals = Images.count_pending_approvals()
pending_approvals = Images.count_pending_approvals(user)
duplicate_reports = DuplicateReports.count_duplicate_reports(user)
reports = Reports.count_reports(user)
artist_links = ArtistLinks.count_artist_links(user)
Expand Down
Loading