Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API key & RSS feed url only show when clicked #205

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Make API key & RSS feed url only show when clicked #205

merged 1 commit into from
Mar 6, 2024

Conversation

EXtremeExploit
Copy link
Contributor

Before you begin

  • I understand my contributions may be rejected for any reason
  • I understand my contributions are for the benefit of Derpibooru and/or the Philomena software
  • I understand my contributions are licensed under the GNU AGPLv3
  • I understand all of the above

Having the API key show in plain sight in the account page is bad practice, there would be risks of people accidentally leaking their API keys because they went to the account page to check something but showing the API key to the public in the process in the case they were sharing their screens or streaming on twitch.
Currently the way i am doing this behaviour is super scuffed, having the box be treated as an image filter is super wrong but its the only way i could think of. Same goes for overriding the initial pass of actions possible to the element which were "unspoilering" the api key.
If theres a better way to do this please tell so, i am very new to elixir/slime/this software, thanks!

@liamwhite
Copy link
Contributor

I would suggest using the data-click-show="#target" attribute for this instead of hacking it to use image templates. Also, you should probably also do this with the RSS endpoint shown in the settings as it uses the same API key.

@EXtremeExploit
Copy link
Contributor Author

EXtremeExploit commented Mar 6, 2024

Thanks for the suggestion, this is how it looks now:
Api key:
image
image

rss feed:
image
image

TODO: all i have to do is the same for the RSS feed url

@EXtremeExploit EXtremeExploit changed the title Make API key only show when clicked Make API key& RSS feed url only show when clicked Mar 6, 2024
@EXtremeExploit EXtremeExploit changed the title Make API key& RSS feed url only show when clicked Make API key & RSS feed url only show when clicked Mar 6, 2024
@liamwhite liamwhite merged commit 7a3b7e6 into philomena-dev:master Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants