match_query: unit test and rewrite for TypeScript #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the match_query clientside parsing library into TypeScript. There should be no substantial logic changes to the internal parse logic here, but three things were discovered during testing and fixed:
substr
JS API. These correspond to the slice method used in the Ruby parser.substring
.This has 100% test coverage in unit tests and has also been manually integration tested.