Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery notifications timestamps #213

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

mdashlw
Copy link
Contributor

@mdashlw mdashlw commented Mar 23, 2024

Before you begin

  • I understand my contributions may be rejected for any reason
  • I understand my contributions are for the benefit of Derpibooru and/or the Philomena software
  • I understand my contributions are licensed under the GNU AGPLv3
  • I understand all of the above

Galleries currently have only one instance of Notification where they are the actor and child actor is nil. Not having a child actor causes that notification to have the same created_at and updated_at fields because child actor is the only thing that ever changes in a Notification. The issue is that notifications page uses notifcation.updated_at timestamp, so currently it displays when the first image was added to a gallery which could be years ago. This PR resolves it by making child actor the added image which forces updated_at to update.

@liamwhite liamwhite merged commit f5642d1 into philomena-dev:master Mar 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants