Autocomplete fallback #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you begin
Local autocompleter currently takes top 50k tags (the cutoff is ~34 images right now). It'd be useful to have autocomplete for tags without that many images, e.g. for artists and OCs. This PR adds it by making autocomplete fallback to fetch if instant returns no results. This approach avoids adding additional 233k tags (
images.gt:0, images.lt:34, (artist:* || oc:*)) to the precompiled binary. This PR also makes the fetch autocomplete return all tags with 1+ images instead of 4+.Also see https://discord.com/channels/430829008402251796/438029140659142657/1175460824924565584