Use GitHub API for downloads #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor common code, and add downloading using GitHub API if a GitHub PAT is given Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>
will-v-pi
force-pushed
the
github-api-downloads
branch
from
bc819d1 to
f944b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the download mechanism for GitHub releases to use the GitHub API for downloads if a PAT is given. This will make it possible for the extension to download from private repositories, if users wish to test private forks of the tools/SDK/etc.
Not using this by default for non-authenticated GitHub requests (ie if no PAT is given), to avoid impacting the rate limit with an additional request for each download.