Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flow type declarations #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −3
Open

add flow type declarations #4

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3938ed0
add flow typ declarations
n1ru4l Oct 26, 2018
485a6ff
update types
n1ru4l Oct 26, 2018
5d142c2
update types
n1ru4l Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
interface ... {
// ...
}

declare export default function use...(): ...;
declare export default function useOnlineStatus(opts: {
onOnline?: () => void,
onOffline?: () => void,
onStatusChange?: (online: boolean) => void,
}): boolean;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar to Flowtype, but could these typings be extracted to a separate type, like my suggestion on the TypeScript PR?

Something like:

interface OnlineStatusOpts {
    onOnline?: () => void,
    onOffline?: () => void,
    onStatusChange?: (online: boolean) => void,
}

export default function useOnlineStatus(opts: OnlineStatusOpts): boolean;