Merge pull request #1 from shadowman-lab/bot/ansible-lint/89077ac3730…

…109c69a2d0b3a96e1a58051476446

Ansible code bot recommendations

ServiceNowCR_and_approve.yml

@@ -1,3 +1,4 @@
+---
 - name: Create and wait for approval of a change request
   hosts: localhost
   gather_facts: false

ServiceNowCR_canceled.yml

@@ -1,10 +1,11 @@
+---
 - name: Cancel a change request
   hosts: localhost
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_cr: "canceled"
+    servicenow_cr: canceled
 
   roles:
     - servicenow_change_request

ServiceNowCR_closed.yml

@@ -1,10 +1,11 @@
+---
 - name: Close a change request
   hosts: localhost
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_cr: "close"
+    servicenow_cr: close
 
   roles:
     - servicenow_change_request

ServiceNowCR_create.yml

@@ -1,10 +1,11 @@
+---
 - name: Create a change request
   hosts: all
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_cr: "create"
+    servicenow_cr: create
 
   roles:
     - servicenow_change_request

ServiceNowCR_deleted.yml

@@ -1,10 +1,11 @@
+---
 - name: Delete a change request
   hosts: localhost
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_cr: "absent"
+    servicenow_cr: absent
 
   roles:
     - servicenow_change_request

ServiceNowCR_implement.yml

@@ -1,10 +1,11 @@
+---
 - name: Implement a change request
   hosts: localhost
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_cr: "implement"
+    servicenow_cr: implement
 
   roles:
     - servicenow_change_request

ServiceNowCatalog.yml

@@ -1,3 +1,4 @@
+---
 - name: Update a catalog item in ServiceNow
   hosts: localhost
   gather_facts: false

ServiceNow_cmdb_update.yml

@@ -1,3 +1,4 @@
+---
 - name: Update CMDB table
   hosts: "{{ vm_name | default('all') }}"
   gather_facts: false

ServiceNowticket.yml

@@ -1,10 +1,11 @@
+---
 - name: Create an incident in ServiceNow using facts from a host
   hosts: "{{ vm_name | default('all')}}"
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_ticket: "create"
+    servicenow_ticket: create
 
   roles:
     - servicenow_ticket

ServiceNowticket_close.yml

@@ -1,10 +1,11 @@
+---
 - name: Close an incident in ServiceNow
   hosts: all
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_ticket: "close"
+    servicenow_ticket: close
 
   roles:
     - servicenow_ticket

ServiceNowticket_eda.yml

@@ -1,10 +1,11 @@
+---
 - name: Create an incident in ServiceNow from EDA
   hosts: "{{ vm_name | default('all')}}"
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_ticket: "createeda"
+    servicenow_ticket: createeda
 
   roles:
     - servicenow_ticket

ServiceNowticket_find.yml

@@ -1,9 +1,10 @@
+---
 - name: Find an incident in ServiceNow
   hosts: localhost
   gather_facts: false
 
   vars:
-    servicenow_ticket: "find"
+    servicenow_ticket: find
 
   roles:
     - servicenow_ticket

ServiceNowticket_inprogress.yml

@@ -1,10 +1,11 @@
+---
 - name: Update an incident in ServiceNow
   hosts: all
   gather_facts: false
   connection: local
 
   vars:
-    servicenow_ticket: "update"
+    servicenow_ticket: update
 
   roles:
     - servicenow_ticket

ServiceNowticket_security.yml

@@ -1,13 +1,14 @@
+---
 - name: Create an incident in ServiceNow for IP Blocking
   hosts: localhost
   gather_facts: false
   connection: local
 
   vars:
-    incident_description: "AAP IP Block"
+    incident_description: AAP IP Block
     sn_urgency: high
     sn_impact: high
-    servicenow_ticket: "create"
+    servicenow_ticket: create
 
   roles:
     - servicenow_ticket

ServiceNowuser_create.yml

@@ -1,3 +1,4 @@
+---
 - name: Create a servicenow admin user
   hosts: localhost
   gather_facts: false

collections/requirements.yml

@@ -1,5 +1,5 @@
+---
 collections:
-
   - name: community.general
 
   - name: servicenow.itsm

roles/servicenow_change_request/defaults/main.yml

@@ -1,3 +1,3 @@
 ---
-servicenow_cr: "create"
+servicenow_cr: create
 to_email: "{{ to_emails.split(',') }}"

roles/servicenow_change_request/tasks/servicenow_create.yml

@@ -3,8 +3,8 @@
   servicenow.itsm.change_request:
     state: new
     type: standard
-    template: "Reboot Windows Server - 1"
-    short_description: "Reboot Windows Server"
+    template: Reboot Windows Server - 1
+    short_description: Reboot Windows Server
     requested_by: admin
     other:
       cmdb_ci: "{{ ip_addr }}"

roles/servicenow_change_request_wait/tasks/main.yml

@@ -6,11 +6,12 @@
       servicenow.itsm.change_request:
         type: normal
         short_description: "{{ cr_description }}"
-        description: "{{ owner | default('Shadowman') }} requests {{ operating_system | default('') }} server in {{ shadowman_provision_hypervisor | default('') }} with name {{ vm_name | default('') }} and environment {{ env | default('test') }}"
+        description: "{{ owner | default('Shadowman') }} requests {{ operating_system | default('') }} server in {{ shadowman_provision_hypervisor | default('') }}
+          with name {{ vm_name | default('') }} and environment {{ env | default('test') }}"
         priority: high
         risk: moderate
         impact: low
-        assignment_group: "CAB Approval"
+        assignment_group: CAB Approval
         state: assess
       register: request
       until: request.changed is defined
@@ -31,8 +32,9 @@
         username: "{{ EMAIL_USERNAME }}"
         password: "{{ EMAIL_PASSWORD }}"
         port: "{{ EMAIL_PORT }}"
-        subject: "Approval request for ServiceNow Change Request {{ request.record.number }}"
-        body: "You have a new CR Approval request. Please click on this URL to approve: {{ lookup('env', 'SN_HOST') }}nav_to.do?uri=change_request.do?sysparm_query=number={{ request.record.number }}"
+        subject: Approval request for ServiceNow Change Request {{ request.record.number }}
+        body: "You have a new CR Approval request. Please click on this URL to approve: {{ lookup('env', 'SN_HOST') }}nav_to.do?uri=change_request.do?sysparm_query=number={{
+          request.record.number }}"
         from: tower@shadowman.dev
         to: "{{ to_email }}"
       delegate_to: localhost
@@ -50,5 +52,5 @@
       servicenow.itsm.change_request:
         state: implement
         number: "{{ request.record.number }}"
-        assignment_group: "CAB Approval"
+        assignment_group: CAB Approval
       delegate_to: localhost

roles/servicenow_ticket/defaults/main.yml

@@ -1,2 +1,2 @@
 ---
-servicenow_ticket: "create"
+servicenow_ticket: create

roles/servicenow_ticket/tasks/servicenow_close.yml

@@ -3,6 +3,6 @@
   servicenow.itsm.incident:
     state: closed
     number: "{{ ticket_number }}"
-    close_code: "Solved (Permanently)"
+    close_code: Solved (Permanently)
     close_notes: "{{ comment }}"
   delegate_to: localhost

roles/servicenow_ticket/tasks/servicenow_create_eda.yml

@@ -21,4 +21,4 @@
 - name: Pass incident number
   ansible.builtin.set_stats:
     data:
-      ticket_number: "{{ new_incident.record.number }}"
+      ticket_number: "{{ new_incident.record.number }}"